Log warning when PROC_MACRO exclusion is used with Cargo Lockfile Detector #1573
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahidblackduck
requested review from
andrian-sevastyanov,
bd-samratmuk,
cpottsbd,
devmehtabd,
dterrybd and
shantyk
devmehtabd
approved these changes
Oct 10, 2025
andrian-sevastyanov
approved these changes
Oct 10, 2025
cpottsbd
requested changes
Oct 15, 2025
| * (IDETECT-4813) Fix Gradle Native Inspector to correctly identify projects with only `settings.gradle` or `settings.gradle.kts` file in the root directory. | ||
| * (IDETECT-4812) Gradle Native Inspector now supports configuration cache (refactored `init-detect.gradle` to add support for configuration cache in Gradle projects). | ||
| * (IDETECT-4845) With added support for extracting Python package versions from direct references [PEP 508 URIs](https://packaging.python.org/en/latest/specifications/dependency-specifiers/#environment-markers) in `pyproject.toml` files, [detect_product_short] now correctly parses versions from wheel and archive URLs and VCS references for impacted detectors (Setuptools CLI, Setuptools Parse, and UV Lock detectors). When data is missing or badly formatted, detectors gracefully switch back to reporting only the package name. | ||
| * (IDETECT-4850) Log warning when `PROC_MACRO` dependency exclusion is used with the Cargo Lockfile Detector. |
There was a problem hiding this comment.
Minor tweak suggestion:
- (IDETECT-4850) Log a warning when unsupported
PROC_MACROdependency exclusion is attempted with the Cargo Lockfile Detector.
karolynbd
approved these changes
Oct 15, 2025
cpottsbd
approved these changes
Oct 15, 2025
zahidblackduck
deleted the
dev/zahidblackduck/IDETECT-4850-log-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
IDETECT-4850
Description
This merge request contains change to log a clear warning message when
PROC_MACROis included in the configured dependency-type exclusions but will be ignored by the Cargo Lockfile Detector.--detect.cargo.dependency.types.excludedacceptsNORMAL,BUILD,DEV, andPROC_MACRO. The Cargo Lockfile Detector cannot identifyPROC_MACRObecause those deps are not represented inCargo.toml/Cargo.lock, so the exclusion will be ignored but was not clearly communicated.PROC_MACROis present in the exclusion filter and the Cargo Lockfile Detector is running.